Skip to content

Fix WeightRule spec#53947

Merged
pierrejeambrun merged 1 commit intoapache:v2-11-testfrom
ZhaoMJ:patch-1
Sep 17, 2025
Merged

Fix WeightRule spec#53947
pierrejeambrun merged 1 commit intoapache:v2-11-testfrom
ZhaoMJ:patch-1

Conversation

@ZhaoMJ
Copy link

@ZhaoMJ ZhaoMJ commented Jul 30, 2025

Remove the enum requirement for WeightRule in OpenAPI spec, since it can be the path of the custom class when a custom weight_rule is used.

Related: #46824

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 30, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

pierrejeambrun
pierrejeambrun approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this is AF2 stuff and that's not super fresh in my mind, I could use a second pair of eyes, just to confirm.

cc: @ephraimbuddy, @jedcunningham

@pierrejeambrun pierrejeambrun added the legacy api Whether legacy API changes should be allowed in PR label Aug 1, 2025
@pierrejeambrun pierrejeambrun reopened this Aug 1, 2025
@eladkal eladkal requested a review from kaxil August 1, 2025 17:00
@eladkal eladkal added this to the Airflow 2.11.1 milestone Aug 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 16, 2025
@Khrol
Copy link
Contributor

Khrol commented Sep 16, 2025

Can I introduce some activity here with my comment? I find this PR useful because we had to patch local Airflow to use a custom weight_rule.

@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 17, 2025
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 17, 2025 •
edited
Loading

Not sure we're going to get a new patch release for 2.11 but here it goes. (merged)

In airflow >= 3.0.0 weight_rule for Task Response object in the API is a string, so upgrading is the way to be sure that this is not a problem anymore.

@pierrejeambrun pierrejeambrun merged commit deb9c79 into apache:v2-11-test Sep 17, 2025
63 of 65 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 17, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal
Copy link
Contributor

eladkal commented Sep 18, 2025

Not sure we're going to get a new patch release for 2.11 but here it goes. (merged)

If not mistaken @potiuk mentioned he is going to do it after #51681 is merged

@ZhaoMJ ZhaoMJ deleted the patch-1 branch September 18, 2025 11:51
potiuk pushed a commit that referenced this pull request Feb 16, 2026
@ZhaoMJ @potiuk
Fix WeightRule spec (#53947)
30ac066
@potiuk potiuk mentioned this pull request Feb 17, 2026
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@kaxil kaxil Awaiting requested review from kaxil

Assignees

No one assigned

Labels

legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Milestone

Airflow 2.11.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ZhaoMJ @Khrol @pierrejeambrun @eladkal

Comments